cool ! could you install the zsh completion as well please ? https://github.com/neovim/neovim/blob/master/contrib/zsh-completion.zsh

Ran :checkhealth for my setup and it went on fine.

cool ! could you install the zsh completion as well please ? neovim/neovim@master/contrib/zsh-completion.zsh

Is this file superior to this ZSH distributed file? I think not. I wonder why upstream decided to maintain that by themselves.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393390

x86_64-linux

aarch64-linux

Everything looks good for me, like the new :checkhealth styling.

Please don't merge yet, I also would want to review it

I will merge the update as is.
Eventual change to the shell completions can be done in a follow-up PR.

I think we lost internationalisation as was mentioned on release notes https://neovim.io/news/2025/03

try export LANG=fr_FR.utf8 for instance on a commit before the update and you have the UI in French.

After this commit not anymore. This fixes it

diff --git i/pkgs/by-name/ne/neovim-unwrapped/package.nix w/pkgs/by-name/ne/neovim-unwrapped/package.nix
index abacc9f3c53d..aeb8b711cd14 100644
--- i/pkgs/by-name/ne/neovim-unwrapped/package.nix
+++ w/pkgs/by-name/ne/neovim-unwrapped/package.nix
@@ -201,6 +201,7 @@ stdenv.mkDerivation (
         # That's because all dependencies were found and
         # third-party/CMakeLists.txt is not read at all.
         (lib.cmakeBool "USE_BUNDLED" false)
+        (lib.cmakeBool "ENABLE_TRANSLATIONS" true)
       ]
       ++ (
         if lua.pkgs.isLuaJIT then

Is this file superior to this ZSH distributed file? I think not. I wonder why upstream decided to maintain that by themselves.

As the ecosystem is overwhelmingly designed, software is responsible to provide its autocompletion. I think it makes sense not to have to wait for a zsh update (which I believe releases less than neovim) to obtain the new flags autocompleted. I added the zsh autocompletion as a matter of fact. I didn't copy the zsh's one because it seemed a tad messy and I was maybe secretly hoping to nerdsnipe someone into improving it. It's probably fine not to bundle it here but I hope that some zsh expert can improve it :)

I think we lost internationalisation as was mentioned on release notes https://neovim.io/news/2025/03

try export LANG=fr_FR.utf8 for instance on a commit before the update and you have the UI in French.

After this commit not anymore. This fixes it

diff --git i/pkgs/by-name/ne/neovim-unwrapped/package.nix w/pkgs/by-name/ne/neovim-unwrapped/package.nix
index abacc9f3c53d..aeb8b711cd14 100644
--- i/pkgs/by-name/ne/neovim-unwrapped/package.nix
+++ w/pkgs/by-name/ne/neovim-unwrapped/package.nix
@@ -201,6 +201,7 @@ stdenv.mkDerivation (
         # That's because all dependencies were found and
         # third-party/CMakeLists.txt is not read at all.
         (lib.cmakeBool "USE_BUNDLED" false)
+        (lib.cmakeBool "ENABLE_TRANSLATIONS" true)
       ]
       ++ (
         if lua.pkgs.isLuaJIT then

Is this file superior to this ZSH distributed file? I think not. I wonder why upstream decided to maintain that by themselves.

As the ecosystem is overwhelmingly designed, software is responsible to provide its autocompletion. I think it makes sense not to have to wait for a zsh update (which I believe releases less than neovim) to obtain the new flags autocompleted. I added the zsh autocompletion as a matter of fact. I didn't copy the zsh's one because it seemed a tad messy and I was maybe secretly hoping to nerdsnipe someone into improving it. It's probably fine not to bundle it here but I hope that some zsh expert can improve it :)

Thanks for the heads up @teto ! Can you make a PR?

PR created at #394024.